Cole-Greer commented on code in PR #3436: URL: https://github.com/apache/tinkerpop/pull/3436#discussion_r3342879201
########## gremlin-tools/gremlin-socket-server/src/main/java/org/apache/tinkerpop/gremlin/socket/server/TestHttpServerInitializer.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.socket.server; + +import io.netty.channel.ChannelInitializer; +import io.netty.channel.socket.SocketChannel; +import io.netty.handler.codec.http.HttpObjectAggregator; +import io.netty.handler.codec.http.HttpServerCodec; + +/** + * Initializes the Netty pipeline for the test HTTP Gremlin server. + */ +public class TestHttpServerInitializer extends ChannelInitializer<SocketChannel> { + + @Override + protected void initChannel(final SocketChannel ch) { + ch.pipeline().addLast(new HttpServerCodec()); + ch.pipeline().addLast(new HttpObjectAggregator(65536)); Review Comment: Adding `gremlin-server` as a dependency would require a larger module realignment to avoid cyclic dependencies, as the driver is still a test-dependency of the server, and gremlin-socket-server is a dependency of the driver. I think there may be an argument that we should flip the direction of the driver-server test-dependency, move the driver integration tests to the gremlin-driver module, and strip the driver out of the server integration tests, but that's a bigger task and adds a lot of risks. Realistically for these tests, the only part of the request they care about is extracting the `gremlin` field from the body. If we switch to JSON requests, I think we can throw together a minimal request parsing handler for the purposes of this test server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
