Cole-Greer commented on code in PR #3428:
URL: https://github.com/apache/tinkerpop/pull/3428#discussion_r3277647629
##########
gremlin-go/driver/graphBinaryDeserializer.go:
##########
@@ -416,6 +418,194 @@ func (d *GraphBinaryDeserializer) readEdge() (*Edge,
error) {
return e, nil
}
+// readGraph reads a GraphBinary 4.0 Graph value (after the 0x10 type code +
0x00
+// value flag have already been consumed). Mirrors
org.apache.tinkerpop.gremlin.
+// structure.io.binary.types.GraphSerializer (Java).
Review Comment:
Similar to above, this comment probably doesn't need to exist. I think the
name is self-descriptive enough.
##########
gremlin-go/driver/graph.go:
##########
@@ -26,7 +26,25 @@ import (
)
// Graph is used to store the graph.
+// In-memory collections of vertices and edges populated by GraphBinary 4.0
+// Graph (0x10) deserialization so that subgraph() results can be returned as
+// a usable data container. Maps are keyed by element id.
Review Comment:
Nit: Might be a bit too much context here, we probably don't want to
remember to update for GraphBinary 5 and such.
```suggestion
// In-memory collections of vertices and edges, typically produced by a
subgraph() traversal. Maps are keyed by element id.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
