kenhuuu commented on code in PR #3403:
URL: https://github.com/apache/tinkerpop/pull/3403#discussion_r3184873658
##########
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary4/StreamExtensions.cs:
##########
@@ -52,10 +53,16 @@ public static async Task WriteByteAsync(this Stream stream,
byte value,
/// <param name="stream">The <see cref="Stream"/> to read from.</param>
/// <param name="cancellationToken">The token to cancel the operation.
The default value is None.</param>
/// <returns>The read <see cref="byte"/>.</returns>
- public static async Task<byte> ReadByteAsync(this Stream stream,
CancellationToken cancellationToken = default)
+ public static async ValueTask<byte> ReadByteAsync(this Stream stream,
Review Comment:
I mean the change from Task to ValueTask is a valid change but was the line
break necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
