Cole-Greer commented on code in PR #3396: URL: https://github.com/apache/tinkerpop/pull/3396#discussion_r3171311400
########## docs/src/upgrade/release-4.x.x.asciidoc: ########## @@ -51,6 +51,34 @@ deserialization in GraphBinary is unchanged. Applications that depend on the `uu `gremlin-javascript` brought it in as a transitive dependency should add it directly to their own `package.json` if they still need it. +==== Python HTTP Streaming Response Support + +The Python driver now streams GraphBinary results directly from the HTTP response body, matching the Go driver's Review Comment: Nit: I don't think it makes sense to compare to the Go driver here, technically go got HTTP streaming first in the TP4 betas, but these upgrade docs should focus on the perspective of TP3.8.x users upgrading to TP4. We will arguably want to rewrite all of these sections once all drivers are done, to either group all streaming updates together, or to better organize sections per-GLV. For the purposes of this PR, I think we should just ensure we capture all the right information from that TP3 upgrade perspective, and then a larger restructuring can follow if/when it makes sense. ########## docs/src/upgrade/release-4.x.x.asciidoc: ########## @@ -51,6 +51,34 @@ deserialization in GraphBinary is unchanged. Applications that depend on the `uu `gremlin-javascript` brought it in as a transitive dependency should add it directly to their own `package.json` if they still need it. +==== Python HTTP Streaming Response Support + +The Python driver now streams GraphBinary results directly from the HTTP response body, matching the Go driver's Review Comment: Nit: I don't think it makes sense to compare to the Go driver here, technically go got HTTP streaming first in the TP4 betas, but these upgrade docs should focus on the perspective of TP3.8.x users upgrading to TP4. We will arguably want to rewrite all of these sections once all drivers are done, to either group all streaming updates together, or to better organize sections per-GLV. For the purposes of this PR, I think we should just ensure we capture all the right information from that TP3 upgrade perspective, and then a larger restructuring can follow if/when it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
