kenhuuu opened a new pull request, #3402: URL: https://github.com/apache/tinkerpop/pull/3402
https://issues.apache.org/jira/browse/TINKERPOP-3247 Moving parameters from binary-serialized maps to string representations makes the request side pure text, decoupling Gremlin language evolution from GraphBinary versioning. New types can be introduced in minor/patch versions without touching GraphBinary, eliminating the need for a major version bump across the ecosystem for every new request-side type. The asParameter() fallback is replaced with an unsupportedType flag that records the class name and falls back to toString(). A flag is used rather than throwing because embedded Traversals build GremlinLang as a side effect but never send it, so unknown types must not break execution. All other GLVs throw immediately since they have no embedded mode and the early throw gives better errors. Client APIs accept both map and string bindings (but not both at the same time) because users who use the Client directly with raw Gremlin strings shouldn't need to hand-craft gremlin-lang map literals. Mixing both throws immediately to prevent silent loss where one set of bindings would be discarded. Edge and VertexProperty tests that relied on the old asParameter fallback were removed because they aren't supported in gremlin-lang. <!-- Thanks for contributing! Reminders: + TARGET the earliest branch where you want the change 3.7-dev -> 3.7.7 (non-breaking only) 3.8-dev -> 3.8.2 (non-breaking only) master -> 4.0.0 + Committers will MERGE the PR forward to newer versions + ADD entry to the CHANGELOG.asciidoc for the targeted version Do not reference a JIRA number there + ADD JIRA number to title and link in description + PRs requires 3 +1s from committers OR 1 +1 and 7 day wait to merge. + MORE details: https://s.apache.org/rtnal --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
