abethini-web opened a new pull request, #3399: URL: https://github.com/apache/tinkerpop/pull/3399
ReplaceGlobalStep and ReplaceLocalStep currently expose oldChar and newChar only as constructor parameters with no public accessors. Graph database implementations that perform ahead-of-time query translation need to inspect these parameters during the translation phase to generate optimized execution plans — for example, to determine whether the replace operation can be pushed down to a native query engine or whether null arguments should be treated as a no-op at translation time. Without getters, translators have no way to access these values from the step object. This PR adds getOldChar() and getNewChar() public getters to both steps. The change is non-breaking and follows the same pattern used by other parameterized steps such as SubstringGlobalStep and SplitGlobalStep. Related: https://code.amazon.com/reviews/CR-268332799 (DFE translation support for replace step) TARGET: 3.8-dev — needed in 3.8.x (3.8.1+) and should be merged forward to master (4.0.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
