Cole-Greer commented on code in PR #3330:
URL: https://github.com/apache/tinkerpop/pull/3330#discussion_r2955179233
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/client-test.js:
##########
@@ -39,41 +38,23 @@ describe('Client', function () {
customClient.submit(query)
});
- it('should allow to configure opProcessor', function () {
+ it('should submit request with custom traversalSource', function () {
const connectionMock = {
- submit: function (processor, op, args, requestId) {
- assert.strictEqual(args.gremlin, query);
- assert.strictEqual(processor, customOpProcessor);
-
+ submit: function (requestMessage) {
+ assert.strictEqual(requestMessage.getGremlin(), query);
+ assert.strictEqual(requestMessage.getG(), 'gCustom');
return Promise.resolve();
}
};
- const customClient = new Client('ws://localhost:9321', {traversalSource:
'g', processor: customOpProcessor, connectOnStartup: false});
+ const customClient = new Client('ws://localhost:9321', {traversalSource:
'gCustom', connectOnStartup: false});
Review Comment:
I've removed all remaining ws references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
