Cole-Greer commented on code in PR #3209:
URL: https://github.com/apache/tinkerpop/pull/3209#discussion_r2372958592
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AbstractAddEdgeStepPlaceholder.java:
##########
@@ -101,6 +87,18 @@ public boolean isParameterized() {
return false;
}
+ @Override
+ public List<Traversal.Admin<?, ?>> getLocalChildren() {
Review Comment:
The `TraversalParent` interface itself does not use generics. The `S` and
`E` type variables are only bound on the `getLocalChildren` method itself. That
means that the `S` and `E` defined in `public default <S, E>
List<Traversal.Admin<S, E>> getLocalChildren()` are not the same `S` and `E`
defined in this implementing step classes.
They should be independent, the addEdge step here uses `<S, Edge>` (can
start with anything and always produces an Edge), but it's child traversals do
not produce edges, the from/to traversals will produce a Vertex or some ID
type, the label traversal will produce a String...
I think it would be most clear if TraversalParent was updated to just return
`List<Traversal.Admin<?, ?>>` instead, however I considered that out of scope
for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
