Cole-Greer commented on code in PR #3212:
URL: https://github.com/apache/tinkerpop/pull/3212#discussion_r2369516876
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/RepeatUnrollStrategy.java:
##########
@@ -56,8 +62,14 @@
public final class RepeatUnrollStrategy extends
AbstractTraversalStrategy<TraversalStrategy.OptimizationStrategy> implements
TraversalStrategy.OptimizationStrategy {
private static final RepeatUnrollStrategy INSTANCE = new
RepeatUnrollStrategy();
- protected static final int MAX_BARRIER_SIZE = 2500;
- private static final Set<Class> INVALIDATING_STEPS = new
HashSet<>(Arrays.asList(LambdaHolder.class, LoopsStep.class));
+ static final int MAX_BARRIER_SIZE = 2500;
+ private static final Set<Class> ALLOWED_STEP_CLASSES = Set.of(
+ VertexStepContract.class,
+ EdgeVertexStep.class,
+ EdgeOtherVertexStep.class,
+ HasStep.class,
+ RepeatStep.class,
Review Comment:
Does this imply that the strategy will unroll nested repeats? Is this
intended and if so, could you add test cases for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
