Cole-Greer commented on code in PR #3209:
URL: https://github.com/apache/tinkerpop/pull/3209#discussion_r2356955740
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/lambda/GValueConstantTraversal.java:
##########
@@ -57,6 +57,17 @@ public boolean equals(final Object other) {
return constantTraversal.equals(other);
}
+ @Override
+ public GValueConstantTraversal<S, E> clone() {
+ GValueConstantTraversal<S, E> clone = new
GValueConstantTraversal<>(GValue.of(this.end.getName(), this.end.get()));
+ try {
+ clone.setGValueManager(this.getGValueManager().clone());
+ } catch (CloneNotSupportedException e) { //TODO:: handle properly
Review Comment:
There needs to be a revisit for cloning of GValues, GValueManager, and
StepPlaceholders. I consider this out of scope for this PR and intend to
address this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
