andreachild commented on code in PR #3121:
URL: https://github.com/apache/tinkerpop/pull/3121#discussion_r2107850158


##########
gremlin-python/src/main/python/radish/gremlin.py:
##########
@@ -701,24 +701,15 @@
     'g_V_order_byXnoX_count': [(lambda g:g.V().order().by('no').count())], 
     'g_V_group_byXlabelX_count': [(lambda 
g:g.V().group().by(T.label).count())], 
     'g_V_group_byXlabelX_countXlocalX': [(lambda 
g:g.V().group().by(T.label).count(Scope.local))], 
-    'g_injectXdatetimeXstrXX_dateAddXDT_hour_2X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour,
 2))], 
-    'g_injectXdatetimeXstrXX_dateAddXhour_2X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour,
 2))], 
-    'g_injectXdatetimeXstrXX_dateAddXhour_1X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour,
 -1))], 
-    'g_injectXdatetimeXstrXX_dateAddXminute_10X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.minute,
 10))], 
-    'g_injectXdatetimeXstrXX_dateAddXsecond_20X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.second,
 20))], 
-    'g_injectXdatetimeXstrXX_dateAddXday_11X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-09-06T00:00+00:00')).date_add(DT.day,
 11))], 
-    'g_injectXDateTimeXstrXX_dateAddXDT_hour_2X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour,
 2))], 
-    'g_injectXDateTimeXstrXX_dateAddXhour_2X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour,
 2))], 
-    'g_injectXDateTimeXstrXX_dateAddXhour_1X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour,
 -1))], 
-    'g_injectXDateTimeXstrXX_dateAddXminute_10X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.minute,
 10))], 
-    'g_injectXDateTimeXstrXX_dateAddXsecond_20X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.second,
 20))], 
-    'g_injectXDateTimeXstrXX_dateAddXday_11X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-09-06T00:00+00:00')).date_add(DT.day,
 11))], 
-    'g_injectXdatetimeXstr1XX_dateDiffXdatetimeXstr2XX': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_diff(datetime.datetime.fromisoformat('2023-08-09T00:00+00:00')))],
 
-    'g_injectXdatetimeXstr1XX_dateDiffXconstantXdatetimeXstr2XXX': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-08T00:00+00:00')).date_diff(__.constant(datetime.datetime.fromisoformat('2023-08-01T00:00+00:00'))))],
 
-    'g_injectXdatetimeXstr1XX_dateDiffXinjectXdatetimeXstr2XXX': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-08T00:00+00:00')).date_diff(__.inject(datetime.datetime.fromisoformat('2023-10-11T00:00+00:00'))))],
 
-    'g_injectXDateTimeXstr1XX_dateDiffXDateTimeXstr2XX': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_diff(datetime.datetime.fromisoformat('2023-08-09T00:00+00:00')))],
 
-    'g_injectXDateTimeXstr1XX_dateDiffXconstantXDateTimeXstr2XXX': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-08T00:00+00:00')).date_diff(__.constant(datetime.datetime.fromisoformat('2023-08-01T00:00+00:00'))))],
 
-    'g_injectXDateTimeXstr1XX_dateDiffXinjectXDateTimeXstr2XXX': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-08T00:00+00:00')).date_diff(__.inject(datetime.datetime.fromisoformat('2023-10-11T00:00+00:00'))))],
 
+    'g_injectXdatetimeXstrXX_dateAddXDT_hour_2X': [(lambda 
g:g.inject(datetime.datetime.fromisoformat('2023-08-02T00:00+00:00'), 
datetime.datetime.fromisoformat('2023-08-02T00:00+00:00')).date_add(DT.hour, 
2))], 

Review Comment:
   I might be missing something obvious but it is unexpected to me that there 
are changes to the `datetime` related tests and no changes to the `sum` tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to