Cole-Greer opened a new pull request, #3103: URL: https://github.com/apache/tinkerpop/pull/3103
Renaming a bunch of types in the grammar to improve consistency and descriptiveness. Some types were redundant and have been removed. The new names all follow the pattern `<baseType>(<CollectionType>)?(Nullable)?(Literal|Argument)(Varargs)?` Previously, many types in the grammar used the suffix `List`, when in practice these were varargs as they did not nest arguments in brackets. These have all been renamed to varargs for consistency. The full list of changes is listed below: Renamings: `genericLiteralArgument` -> `genericArgument` `structureVertex` -> `structureVertexLiteral` `stringLiteralVarargsArgument` -> `stringNullableArgumentVarargs` `genericLiteralMapArgument` -> `genericMapArgument` `genericLiteralMapNullable` -> `genericMapNullableLiteral` `genericLiteralMapNullableArgument` -> `genericMapNullableArgument` `traversalStrategyList` -> `traversalStrategyVarargs` `genericLiteralVarargs` -> `genericArgumentVarags` `genericLiteralCollection` -> `genericCollectionLiteral` // Could rename to genericListLiteral now that `List` is no longer refers to varargs `genericLiteralList` -> `genericLiteralVarargs` `genericLiteralRange` -> `genericRangeLiteral` // Note: should maybe be split into separate `integerRangeLiteral` and `stringRangeLiteral` `stringLiteralVarargs` -> `stringNullableLiteralVarargs` `genericLiteralMap` -> `genericMapLiteral` Changes: Remove `genericLiteralListArgument` in favour of `genericArgumentVarags` // only used by P.within and P.without Remove `stringLiteralList` in favour of `stringNullableLiteralVarargs` // was previously unused -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
