This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/main by this push:
     new 1d80e1d07 TIKA-4311: improve TODO comment
1d80e1d07 is described below

commit 1d80e1d07aaf6b190e8e358975b28d1eba392254
Author: Tilman Hausherr <[email protected]>
AuthorDate: Wed Sep 18 09:01:02 2024 +0200

    TIKA-4311: improve TODO comment
---
 .../main/java/org/apache/tika/parser/pdf/PDFMarkedContent2XHTML.java    | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFMarkedContent2XHTML.java
 
b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFMarkedContent2XHTML.java
index d12e18c81..5ee8cbab6 100644
--- 
a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFMarkedContent2XHTML.java
+++ 
b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFMarkedContent2XHTML.java
@@ -278,6 +278,8 @@ public class PDFMarkedContent2XHTML extends PDF2XHTML {
                 ((COSObject) kids).getObject() instanceof COSDictionary) {
             //TODO should be merged with COSDictionary segment below?
             // and maybe dereference COSObject first, i.e. before the first 
"if"?
+            // No, because we're using the object key for a map
+            // However, we could replace ObjectRef with COSBase for 
currentPageRef. 
             COSDictionary dict = (COSDictionary) ((COSObject) 
kids).getObject();
             COSName type = dict.getCOSName(COSName.TYPE);
             if (COSName.OBJR.equals(type)) {

Reply via email to