This is an automated email from the ASF dual-hosted git repository.
chenli pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new 39270ec8d4 fix(ui): remove labels from dynamically added ports (#4140)
39270ec8d4 is described below
commit 39270ec8d40aecd2bdefcebeb021e2807675ac0b
Author: Seongjin Yoon <[email protected]>
AuthorDate: Mon Dec 29 21:06:33 2025 -0800
fix(ui): remove labels from dynamically added ports (#4140)
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
This PR removes the automatic labeling of dynamically added input and
output ports. Previously, when users added new ports to operators, the
ports were automatically labeled with their port IDs which caused
inconsistencies (e.g., "input-1", "input-2", "output-1", "output-2").
**Changes:**
- Modified the `addPort` method in `WorkflowActionService` to set the
`displayName` to an empty string instead of using the `portID`
- This change affects all dynamically added ports (both input and
output)
**Before:**
<img width="441" height="198" alt="Screenshot 2025-12-29 at 4 07 24 PM"
src="https://github.com/user-attachments/assets/ced2f0a9-bdcf-4eff-9865-becf63e4466f";
/>
**After:**
<img width="270" height="181" alt="Screenshot 2025-12-29 at 4 07 31 PM"
src="https://github.com/user-attachments/assets/f98a27de-31a4-45f2-a75e-5b61fd658468";
/>
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
This PR resolves #3894.
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Tested manually.
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
No.
---
.../workspace/service/workflow-graph/model/workflow-action.service.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts
b/frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts
index 40092419fd..ddee22465a 100644
---
a/frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts
+++
b/frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts
@@ -249,7 +249,7 @@ export class WorkflowActionService {
const port: PortDescription = {
portID,
- displayName: portID,
+ displayName: "",
allowMultiInputs,
isDynamicPort: true,
dependencies: [],
