This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch chart-customization-text-changes in repository https://gitbox.apache.org/repos/asf/superset.git
commit e1f9ffda41ad3b3e944373330b9258b92f71d9cf Author: Maxime Beauchemin <[email protected]> AuthorDate: Tue Jan 27 05:24:48 2026 +0000 refactor(dashboard): update chart customization UI text to display controls Change user-facing text from "chart customization" terminology to "display controls" for better clarity: - Filter bar header: "Actions" → "Filters and controls" - Modal title: "Filters and customization settings" → "Add or edit display controls" - Settings panel: "Customization Settings" → "Display control settings" - Sidebar header: "Chart customizations" → "Display controls" - Section subheader: "Chart Customization" → "Display controls" - Badge tooltip: "Chart Customization/customizations" → "Display controls" Updated corresponding test files to reflect the new text. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --- .../src/dashboard/components/CustomizationsBadge/index.tsx | 4 ++-- .../nativeFilters/FilterBar/FilterControls/FilterControls.tsx | 2 +- .../components/nativeFilters/FilterBar/Header/Header.test.tsx | 4 ++-- .../src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx | 2 +- .../dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx | 4 ++-- .../FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx | 2 +- .../FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx | 2 +- .../nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx b/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx index 6f7fc988b5..b67a99e275 100644 --- a/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx +++ b/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx @@ -243,7 +243,7 @@ export const CustomizationsBadge = ({ chartId }: CustomizationsBadgeProps) => { <TooltipContent> <div> <SectionName> - {t('Chart Customization (%d)', effectiveCustomizations.length)} + {t('Display controls (%d)', effectiveCustomizations.length)} </SectionName> <GroupByInfo> {effectiveCustomizations.map(customization => { @@ -291,7 +291,7 @@ export const CustomizationsBadge = ({ chartId }: CustomizationsBadgeProps) => { > <StyledTag ref={triggerRef} - aria-label={t('Chart customizations (%s)', customizationsCount)} + aria-label={t('Display controls (%s)', customizationsCount)} role="button" tabIndex={0} > diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx index c94537da85..1dbc0a4c86 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx @@ -366,7 +366,7 @@ const FilterControls: FC<FilterControlsProps> = ({ lineHeight: 1.3, }} > - {t('Chart Customization')} + {t('Display controls')} </Title> <StyledIcon iconSize="m" diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/Header.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/Header.test.tsx index ebf0fa2501..5161191c54 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/Header.test.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/Header.test.tsx @@ -29,10 +29,10 @@ test('should render', () => { expect(container).toBeInTheDocument(); }); -test('should render the "Actions" heading', () => { +test('should render the "Filters and controls" heading', () => { const mockedProps = createProps(); render(<Header {...mockedProps} />, { useRedux: true }); - expect(screen.getByText('Actions')).toBeInTheDocument(); + expect(screen.getByText('Filters and controls')).toBeInTheDocument(); }); test('should render the expand button', () => { diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx index 40668e5e52..b0c903c030 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx @@ -69,7 +69,7 @@ type HeaderProps = { const Header: FC<HeaderProps> = ({ toggleFiltersBar }) => ( <Wrapper> <TitleArea> - <span>{t('Actions')}</span> + <span>{t('Filters and controls')}</span> <FilterBarSettings /> <HeaderButton {...getFilterBarTestId('collapse-button')} diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx index 3c616e4491..1dc55f91df 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx @@ -327,13 +327,13 @@ test('open modal on edit filter button click', async () => { expect( screen.queryByRole('dialog', { - name: /filters and customization settings/i, + name: /add or edit display controls/i, }), ).not.toBeInTheDocument(); userEvent.click(editButton); expect( await screen.findByRole('dialog', { - name: /filters and customization settings/i, + name: /add or edit display controls/i, }), ).toBeInTheDocument(); }); diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx index 83e51de272..9d542be04e 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx @@ -127,7 +127,7 @@ const ConfigModalSidebar: FC<ConfigModalSidebarProps> = ({ const customizationsHeader: ReactNode = ( <div> - {t('Chart customizations')} ({chartCustomizationIds.length}) + {t('Display controls')} ({chartCustomizationIds.length}) </div> ); diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx index a1efbf0251..a6ce00d78f 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx @@ -225,7 +225,7 @@ export const CustomizationPanels = { }, settings: { key: 'settings', - name: t('Customization Settings'), + name: t('Display control settings'), }, }; diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx index e1ad879c63..659f0154c8 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx @@ -503,7 +503,7 @@ function FiltersConfigModal({ <BaseModalWrapper open={isOpen} maskClosable={false} - title={t('Filters and customization settings')} + title={t('Add or edit display controls')} expanded={expanded} destroyOnHidden onCancel={handleCancel}
