This is an automated email from the ASF dual-hosted git repository. elizabeth pushed a commit to branch elizabeth/fix-resize-bug in repository https://gitbox.apache.org/repos/asf/superset.git
commit cb49d532295d1a8bee67c9c7cb0e26a91a8c7f71 Author: Enzo Martellucci <[email protected]> AuthorDate: Mon Jul 28 13:39:10 2025 +0200 style(FastVizSwitcher): Adjust padding for FastVizSwitcher selector (#34317) --- .../src/dashboard/components/gridComponents/Tabs.jsx | 1 - .../components/controls/VizTypeControl/FastVizSwitcher.tsx | 13 +++---------- .../explore/components/controls/VizTypeControl/VizTile.tsx | 3 ++- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx b/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx index aeaa1154ea..13c514379a 100644 --- a/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx +++ b/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx @@ -96,7 +96,6 @@ const StyledTabsContainer = styled.div` .ant-tabs-content-holder { overflow: visible; - padding-top: ${theme.sizeUnit * 4}px; } } diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/FastVizSwitcher.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/FastVizSwitcher.tsx index 96d54dab29..cd7203350c 100644 --- a/superset-frontend/src/explore/components/controls/VizTypeControl/FastVizSwitcher.tsx +++ b/superset-frontend/src/explore/components/controls/VizTypeControl/FastVizSwitcher.tsx @@ -19,7 +19,7 @@ import { memo, useMemo } from 'react'; import { useSelector } from 'react-redux'; import { css, SupersetTheme } from '@superset-ui/core'; -import { Icons } from '@superset-ui/core/components/Icons'; +import { Flex, Icons } from '@superset-ui/core/components'; import { getChartKey } from 'src/explore/exploreUtils'; import { ExplorePageState } from 'src/explore/types'; import { FastVizSwitcherProps } from './types'; @@ -79,14 +79,7 @@ export const FastVizSwitcher = memo( }, [currentSelection, currentViz]); return ( - <div - css={(theme: SupersetTheme) => css` - display: flex; - justify-content: space-between; - column-gap: ${theme.sizeUnit}px; - `} - data-test="fast-viz-switcher" - > + <Flex justify="space-between" gap={4} data-test="fast-viz-switcher"> {vizTiles.map(vizMeta => ( <VizTile vizMeta={vizMeta} @@ -96,7 +89,7 @@ export const FastVizSwitcher = memo( key={vizMeta.name} /> ))} - </div> + </Flex> ); }, ); diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx index 5d7e65e8da..09bf2c755e 100644 --- a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx +++ b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx @@ -124,7 +124,7 @@ export const VizTile = ({ > <span css={css` - padding: 0px ${theme.sizeUnit}px; + padding: 0px ${theme.sizeUnit * 1.25}px; `} > {vizMeta.icon} @@ -136,6 +136,7 @@ export const VizTile = ({ font-size: ${theme.fontSizeSM}px; min-width: 0; padding-right: ${theme.sizeUnit}px; + line-height: 1; `} ref={chartNameRef} >
