This is an automated email from the ASF dual-hosted git repository.
paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/sedona-db.git
The following commit(s) were added to refs/heads/main by this push:
new 2138d34 chore: Fix clippy errors from newer Rust and pin Python
version (#266)
2138d34 is described below
commit 2138d34c9c9675bb5217ca84fc700fc21128e196
Author: Dewey Dunnington <[email protected]>
AuthorDate: Fri Oct 31 13:18:02 2025 -0500
chore: Fix clippy errors from newer Rust and pin Python version (#266)
---
.github/workflows/packaging.yml | 2 +-
.github/workflows/python.yml | 2 +-
c/sedona-geos/src/st_buffer.rs | 3 +--
rust/sedona-geometry/src/wkb_header.rs | 21 +++++++--------------
4 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml
index 4e640fa..540d96c 100644
--- a/.github/workflows/packaging.yml
+++ b/.github/workflows/packaging.yml
@@ -45,7 +45,7 @@ jobs:
submodules: 'true'
- uses: actions/setup-python@v5
with:
- python-version: "3.x"
+ python-version: "3.13"
- name: Prepare dev version
shell: bash
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
index fd242e5..3d148f4 100644
--- a/.github/workflows/python.yml
+++ b/.github/workflows/python.yml
@@ -63,7 +63,7 @@ jobs:
- uses: actions/setup-python@v4
with:
- python-version: '3.x'
+ python-version: '3.13'
cache: 'pip'
- name: Clone vcpkg
diff --git a/c/sedona-geos/src/st_buffer.rs b/c/sedona-geos/src/st_buffer.rs
index 2af2e62..2269faf 100644
--- a/c/sedona-geos/src/st_buffer.rs
+++ b/c/sedona-geos/src/st_buffer.rs
@@ -624,8 +624,7 @@ mod tests {
// Expected area with GEOS 3.13 (improved algorithm without artifacts)
assert!(
(area_right - 12713.605978550266).abs() < 0.1,
- "Expected GEOS 3.13+ area ~12713.61, got {}",
- area_right
+ "Expected GEOS 3.13+ area ~12713.61, got {area_right}"
);
}
diff --git a/rust/sedona-geometry/src/wkb_header.rs
b/rust/sedona-geometry/src/wkb_header.rs
index 22f49a3..e5179b2 100644
--- a/rust/sedona-geometry/src/wkb_header.rs
+++ b/rust/sedona-geometry/src/wkb_header.rs
@@ -359,8 +359,7 @@ fn calc_dimensions(code: u32) -> Result<Dimensions,
SedonaGeometryError> {
2 => Ok(Dimensions::Xym),
3 => Ok(Dimensions::Xyzm),
_ => Err(SedonaGeometryError::Invalid(format!(
- "Unexpected code: {:?}",
- code
+ "Unexpected code: {code:?}"
))),
}
}
@@ -904,8 +903,7 @@ mod tests {
for i in 1..wkb.len() - 1 {
assert!(
WkbHeader::try_new(&wkb[0..i]).is_err(),
- "0..{} unexpectedly succeeded",
- i
+ "0..{i} unexpectedly succeeded"
);
}
@@ -917,8 +915,7 @@ mod tests {
for i in 1..last_i {
assert!(
WkbHeader::try_new(&wkb[0..i]).is_err(),
- "0..{} unexpectedly succeeded",
- i
+ "0..{i} unexpectedly succeeded"
);
}
@@ -930,8 +927,7 @@ mod tests {
for i in 1..last_i {
assert!(
WkbHeader::try_new(&wkb[0..i]).is_err(),
- "0..{} unexpectedly succeeded",
- i
+ "0..{i} unexpectedly succeeded"
);
}
}
@@ -947,8 +943,7 @@ mod tests {
for i in 1..last_i {
assert!(
WkbHeader::try_new(&wkb[0..i]).is_err(),
- "0..{} unexpectedly succeeded",
- i
+ "0..{i} unexpectedly succeeded"
);
}
@@ -958,8 +953,7 @@ mod tests {
for i in 1..last_i {
assert!(
WkbHeader::try_new(&wkb[0..i]).is_err(),
- "0..{} unexpectedly succeeded",
- i
+ "0..{i} unexpectedly succeeded"
);
}
@@ -969,8 +963,7 @@ mod tests {
for i in 1..last_i {
assert!(
WkbHeader::try_new(&wkb[0..i]).is_err(),
- "0..{} unexpectedly succeeded",
- i
+ "0..{i} unexpectedly succeeded"
);
}
}