SEZ9 commented on PR #13119: URL: https://github.com/apache/seatunnel/pull/13119#issuecomment-6963837139
@lxcxjxhx thanks for confirming that nothing was pushed after `78a6e853`. There is still one change needed before this can go in, plus two small cleanups. **Relative source links (needs a change)** @davidzollo's point is right: the docs are synchronized to seatunnel-website and built there, and that repo does not contain source files such as `LogicalDag.java`. This is the open side of the earlier note on these links: the 15 new relative source links resolve at this head, but only in GitHub rendering, and nothing checks them automatically. They will not resolve on the official website. Please change the 15 links to a form that does not depend on the source tree sitting next to the docs. Absolute GitHub URLs are one option. @davidzollo, could you confirm which form you prefer, so this only needs one revision? **Smaller items from the earlier review** - **Description claim:** "after: 0 pages with en/zh source-link drift" does not hold yet. The zh `engine-architecture.md` and zh `source-architecture.md` still lack source links that their en counterparts carry. Please either add them in the same link form, or reword the description to match what this PR covers. - **Placeholder sentence:** in zh `multi-table.md`, the new subsections are appended after a placeholder sentence that only made sense while the References section was empty. Please remove or reword it. Once the link form is settled and these are updated, I'm happy to take another look. <!-- streview-comment:2421 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
