DanielLeens commented on code in PR #13154:
URL: https://github.com/apache/seatunnel/pull/13154#discussion_r4598450085
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/SubPlan.java:
##########
@@ -559,6 +610,9 @@ private boolean prepareRestorePipeline() {
synchronized (restoreLock) {
try {
pipelineRestoreNum.getAndIncrement();
+ // Record why this run ended before anything clears it:
reset() runs just below
+ // and initStateFuture() replaces errorByPhysicalVertex
outright.
+ retainRestoreCause(pipelineRestoreNum.get(),
errorByPhysicalVertex.get());
Review Comment:
Thanks for checking. The retained list belongs to each `SubPlan`, and the
diagnostic response attaches it to that pipeline rather than to a shared
job-level list. So two pipelines can both record a first retry while keeping
separate causes. My existing approval on `8701e643` stands; the current Build
is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]