SEPURI-SAI-KRISHNA commented on PR #13092:
URL: https://github.com/apache/seatunnel/pull/13092#issuecomment-6897172221

   @SEZ9 Your 04:31Z notes match the earlier version. The current head has no 
`isNullableSplitKey`, no NULL probe, no NULL split and no `IS NOT NULL` 
predicate, so F3, F4, F5, F8 and the hash note no longer apply.
   
   Your two questions of 14 Nov:
   
   1. The automatic choice never runs for a `query`. 
`ChunkSplitter#findSplitKey` returns no key for a `query` without 
`partition_column`, so it is read as one split, and the NULL rows of an outer 
join are read. In `6a59aa1a32` the docs and the Javadoc of 
`isAutomaticSplitColumn` say this.
   2. The `incompatible-changes.md` entry (EN and ZH) now says that a table 
split on a nullable primary key or unique key column is split on the next NOT 
NULL key column, or read as one split, with a WARN naming each skipped column, 
and that `partition_column` jobs are unchanged. The split key sections do not 
mention a NULL split.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to