DanielLeens commented on PR #11814:
URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6850575194

   Thanks @SEZ9 for naming F7 and F8 explicitly. I checked the current head 
`06a7b0ac4f416252b4234dd4f8af48d0e9f3b414` and the two RequestBody 
implementations to answer those points:
   
   - **F7:** Redirects are explicitly disabled in 
[createHttpClient](https://github.com/apache/seatunnel/blob/06a7b0ac4f416252b4234dd4f8af48d0e9f3b414/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandler.java#L272):
 `.followRedirects(false)` and `.followSslRedirects(false)` at lines 284-285. 
The existing 
[testDoesNotFollowRedirects](https://github.com/apache/seatunnel/blob/06a7b0ac4f416252b4234dd4f8af48d0e9f3b414/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandlerTest.java#L238)
 supplies a 307 Location and an Authorization header, verifies that the 
original endpoint received the request, and asserts that the redirect target 
receives none. This is present code/test evidence, not a new local test run.
   - **F8:** For the handler's `MediaType.parse("application/json")`, both 
OkHttp 2.7.5 `RequestBody.create(MediaType, String)` (RequestBody.java:46-56) 
and OkHttp 4.12.0 `String.toRequestBody`, exposed to Java as `create(String, 
MediaType)` (RequestBody.kt:105-118), append `; charset=utf-8` when the media 
type has no charset and encode with UTF-8. Thus this change does not newly 
introduce that charset suffix. The [current regression 
assertion](https://github.com/apache/seatunnel/blob/06a7b0ac4f416252b4234dd4f8af48d0e9f3b414/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandlerTest.java#L189)
 expects exactly `application/json; charset=utf-8`. I compared the dependency 
source implementations; I did not execute an old/new wire-capture test.
   
   These pointers address the two outstanding questions without asking the 
author to duplicate code already present. Please retain your own verification 
step for F1-F8; I am not resolving your review threads on your behalf. My 
technical approval and the green exact-head CI remain separate from the 
required maintainer approval/dismissal gate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to