SEZ9 commented on PR #11077: URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-6817740570
@hesam-oxe thanks for picking this back up — no worries about the gap. One note before the combined push, so you don't redo work: please check the current head `8b383c04ee` against F1–F8 before re-implementing anything. Several of those points are already addressed there (IOException handling around writer creation, per-alias context registration, the shared-destination schema check, and the shared-writer grouping in `MultiTableSinkWriter`). If you believe a gap still remains for F1 (destination-key collisions) or F2 (aliased state on restore), the cheapest way to settle it is a focused test that fails on the current code rather than a rewrite. Please keep the existing coverage intact either way. Docs/Javadoc for F4, F6 and F8 (the `getPhysicalDestinationIdentifier()` and writer-sharing behavior, the implementer-facing `restoreWriter` contract, and the parameter/return tags on `getDestinationKey`) are welcome in the same push, along with the remaining blocking items already called out in the earlier head-review comment. Once the new head is up, ping me and I'll do a full re-review. <!-- streview-comment:2290 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
