DanielLeens commented on issue #13205:
URL: https://github.com/apache/seatunnel/issues/13205#issuecomment-6766879165

   Thanks for disclosing the vendor relationship and for aligning the proposal 
with the existing CLI provider pattern. Current `dev` already has 
`OrcaRouterProvider`, an `OpenAIProvider` subclass with its own key, default 
endpoint/model, registry entry, init-wizard route, config/status handling, 
tests, and bilingual documentation. A separate Standard Compute provider can 
follow that localized shape.
   
   Please keep it independent from #12552. That open provider PR changes the 
same registry, CLI, tests, and documentation, but it is not an implementation 
lane for Standard Compute; rebase on current `dev` and resolve any central-file 
conflicts there.
   
   For a focused PR, please ensure that:
   
   1. `STANDARDCOMPUTE_API_KEY` is the only credential accepted by this 
provider; it must never fall back to `OPENAI_API_KEY`.
   2. Provider registration, `--provider`, `--init`, config-file model 
overrides, `/config`, and `/status` all select the same provider and preserve 
existing providers.
   3. Mocked tests cover defaults, environment overrides, the missing-key 
error, streaming, tool calls, and reasoning-content replay both when the field 
is present and absent. No real key or vendor response should enter the test 
suite.
   4. The English and Chinese docs state the exact environment variables and 
behavior. Any routing, residency, retention, or privacy statement must be 
limited to a documented provider contract rather than an unverified SeaTunnel 
guarantee.
   
   A manual live check may be reported in the PR, but credentials and prompt 
content must not be committed or posted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to