DanielLeens commented on PR #13180:
URL: https://github.com/apache/seatunnel/pull/13180#issuecomment-6755937274

   Thanks @JAEKWANG97 for reproducing this and for coordinating instead of 
pushing a competing change.
   
   For context, this is Issue 1 from my review: `TransformLifecycle.open()` 
(`seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/TransformLifecycle.java:89`)
 catches only `Exception`, so an `Error` such as `LinkageError` skips cleanup 
of children that already opened. I rated it low and non-blocking because the 
task fails anyway and the engine's later `close()` still releases those 
children.
   
   From the reviewer side, my suggestion is a focused follow-up PR after this 
one merges. The current head `c085127c` is approved and its fork CI is fully 
green, and your patch also widens the construction and shutdown paths, which is 
easier to review on its own with its regression tests. Please link it to #13131 
/ #13099 so the lifecycle work stays traceable. Of course, if @goutamadwant 
prefers to fold it in here, that works too; I would re-review the new head.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to