nzw921rx commented on code in PR #25:
URL: https://github.com/apache/seatunnel-shade/pull/25#discussion_r4509845170


##########
seatunnel-shade-hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/MembershipManager.java:
##########
@@ -399,6 +399,7 @@ void updateMembers(MembersView membersView) {
         }
 
         for (MemberImpl member : removedMembers) {
+            clusterService.getClusterJoinManager().addLeftMember(member);

Review Comment:
   Shade ships its own `MembershipManager`, so upgrading to Hazelcast 5.1.7 
picks up the departed-UUID check in `ClusterJoinManager`. This line restores 
the matching call in `MembershipManager.updateMembers()`, which records the 
departed UUID when a follower applies the master's membership update. 
[Hazelcast #23505](https://github.com/hazelcast/hazelcast/pull/23505)
   
   In a local three-member Zeta test, a replacement joined at the same address 
with a new UUID. After the follower became master, we replayed the old join 
request through the join handler. Without this line, the handler removed the 
replacement member. With it, the handler ignored the stale request and the 
replacement stayed in the cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to