DanielLeens commented on issue #13189: URL: https://github.com/apache/seatunnel/issues/13189#issuecomment-6739659193
Thanks for the unusually complete design. The tracker row is now reserved for this design discussion, but it is not yet an implementation approval or an assignment. The unresolved NetSuite facts are on the critical path, not edge cases. Before opening a connector PR, please add sanitized evidence from a NetSuite sandbox or another authoritative runnable fixture for: the actual checkbox/date/timestamp and null response encodings, the SuiteQL `TO_CHAR` behavior and time-zone semantics, the 100000-result boundary, and the token endpoint signing/refresh behavior. MockWebServer tests are still required, but they cannot establish those provider contracts by themselves. The implementation proposal must also define a safe identifier contract for `table`, selected columns and `key_column`; these must not become unrestricted string interpolation. Keep the reader bounded and single-split for v1, keep secrets out of logs/checkpoint state, retain hostname/TLS verification, and make any endpoint override clearly test-oriented and documented. Please return here with that evidence and a narrowed option contract before code starts; then we can decide the module and test matrix without duplicating the existing HTTP connectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
