chovy-3012 commented on PR #13183:
URL: https://github.com/apache/seatunnel/pull/13183#issuecomment-6738459431

   Thanks @DanielLeens for the review and approval! Both nits are addressed in 
b438e8e1b0.
   
   **Nit 1 — inline FQN in `DorisCatalogTest`**
   Imported `java.lang.reflect.Field` and used the simple name in `setUp()`. I 
kept the reflection itself and did not add the optional package-private setter, 
to avoid widening `DorisCatalog`'s API surface just for tests.
   
   **Nit 2 — cleanup on failure in `DorisCatalogIT.testTruncateTable`**
   Wrapped the existing-table phase in `try { ... } finally { 
catalog.dropTable(tablePath, true); }`, moved 
`assertFalse(catalog.tableExists(tablePath))` after the finally, and kept the 
missing-table assertions last. The finally uses `true` (a `DROP TABLE IF 
EXISTS` no-op) so a failed `createTable` cannot be masked by a cleanup 
exception.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to