lukangyu commented on PR #13186:
URL: https://github.com/apache/seatunnel/pull/13186#issuecomment-6732251506

   Thanks for the detailed review, @DanielLeens — all three points are 
addressed in c2606e5.
   
   1. **Issue 1 fixed.** `test.xyz` now shows `id_S, name_S, age_S` in both 
`docs/en` and `docs/zh`. Confirmed against `FieldRenameTransform.java`: the 
suffix is appended at lines 206-211, after `convert_case` runs, so it is not 
case-converted.
   2. **Ordering note added.** The `prefix`, `suffix` and 
`replacements_with_regex` sections now state explicitly that the 
prefix/suffix/`replace_to` text is not case-converted, with a `convert_case = 
"UPPER"` + `replace_to = "_x"` example.
   3. **CI.** Actions are enabled on my fork and the Build workflow ran green 
on this commit: https://github.com/lukangyu/seatunnel/actions/runs/42553794878 
— `Run / Code style`, `Run / Dead links`, `Run / License header` and `Run / 
Build website` all passed. The PR's own `PR signal` run is still 
`action_required` (first-time contributor), so no Build check run has been 
created on this repo yet. Could you approve the pending workflow run when you 
get a chance?
   
   Let me know if anything else needs adjusting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to