DanielLeens commented on PR #12958:
URL: https://github.com/apache/seatunnel/pull/12958#issuecomment-6730842749

   Thanks @Nikk8091. A quick gate update on the unchanged head 
`c7e0a519ead8d61c1bbfd51b19b0723e0bbfb805`: the fork Build 
(https://github.com/Nikk8091/seatunnel/actions/runs/42193801047) finished green 
(no failed jobs), so CI is no longer pending. That was the only item in my last 
conclusion besides the review itself, and my source conclusion is unchanged.
   
   One new fact: since my review, `dev` moved on and GitHub now reports this PR 
as having merge conflicts (DIRTY, ahead 6 / behind 33). The overlap is in files 
this PR also edits: `docs/en/engines/zeta/rest-api-v2.md`, 
`docs/zh/engines/zeta/rest-api-v2.md`, both `incompatible-changes.md` pages, 
`RestApiIT.java` and `RestApiSubmitJobConfigShadeDecryptTest.java`.
   
   Suggested next step: please merge the latest `dev` and resolve those 
conflicts. The resolved head will need a fresh Build, and I will re-check it 
and approve if the diff stays the same as what I reviewed. Thanks for keeping 
this focused through the rebases!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to