DanielLeens opened a new pull request, #13192:
URL: https://github.com/apache/seatunnel/pull/13192

   ### Purpose of this pull request
   
   Close #13191.
   
   `HudiRecordConverter#getHoodieKey` generates a random UUID record key when 
`record_key_fields` is omitted for `INSERT`. `BULK_INSERT` takes the append 
path but currently falls through to `getRecordKey`, which dereferences the null 
`record_key_fields` and throws a `NullPointerException`. This change applies 
the existing UUID behavior to both append operations and leaves `UPSERT` 
validation unchanged.
   
   The Hudi sink E2E now writes three rows with `BULK_INSERT` and no 
`record_key_fields`, then verifies three distinct 36-character UUID record keys 
from the committed Parquet file. A connector unit test verifies that `INSERT` 
and `BULK_INSERT` both produce distinct UUID keys. English and Chinese 
connector documents describe the resulting behavior.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. A `BULK_INSERT` job without `record_key_fields` previously failed with 
a `NullPointerException`; it now appends rows with random UUID record keys, 
matching the existing `INSERT` behavior. `UPSERT` still requires 
`record_key_fields`, and explicitly configured record keys keep their behavior.
   
   ### How was this patch tested?
   
   - Added `HudiTest#testGeneratedKeysForAppendOperationsWithoutConfiguredKey` 
for `INSERT` and `BULK_INSERT` UUID generation.
   - Added `HudiIT#testBulkInsertWithoutRecordKey` and 
`fake_to_hudi_bulk_insert_without_key.conf` to verify three committed rows with 
three distinct UUID record keys.
   - Validation is performed by GitHub CI on this PR head; no local functional 
test or Docker test was run.
   
   ### Check list
   
   * [x] If any new Jar binary package adding in your PR, please add License 
Notice according [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [x] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [x] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [x] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to