goutamadwant opened a new pull request, #13175:
URL: https://github.com/apache/seatunnel/pull/13175
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
Yes, I am contributing this fix to SeaTunnel.
Fixes #13132.
Stop Zeta task startup at the first transform initialization exception and
propagate the original failure. Reject records after failed initialization,
close transform-stage resources through their existing lifecycle owner, and
preserve the startup failure when cleanup also throws. Guard failed-startup
cleanup against a later worker close.
Task-wide teardown remains separate in #12231 / #12391.
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
### Does this PR introduce _any_ user-facing change?
Yes. Current `dev` logs a transform `open()` failure and continues opening
the chain. This patch fails startup instead, including jobs with no input rows.
`LOG` and `ROUTE` row-error handling cannot recover an initialization failure.
English and Chinese docs describe this behavior.
Successful startup, transform interfaces and configuration remain unchanged.
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
- Reproduced against unchanged production code: all 12 new startup-failure
regression cases failed because `open()` returned without throwing.
- JDK 11 scoped reactor `verify`: 95 tests passed, with no failures, errors
or skips. Coverage includes first/middle/last failure, map/flat-map wrappers,
task startup state, partial resource cleanup, cleanup failures, repeated close,
ROUTE handler close delegation and healthy controls.
- Extended `LocalModeIT.transformStartupFailureFailsEmptyAndNonemptyJobs`:
four parameterized cases passed with 0/1 input rows and cooperative `ALL` /
blocking `OFF` modes. Each case runs a failing job followed by a healthy job,
eight jobs total. Assertions check job status, original failure text, later
transforms staying unopened, zero output after failure and transform cleanup.
- The selected IT method was compiled against freshly built engine classes
and run directly through JUnit Platform, not Maven Failsafe.
- Scoped Spotless checks and `git diff --check` passed.
Focused Maven selection:
```sh
./mvnw -Pci \
-pl
seatunnel-engine/seatunnel-engine-server,seatunnel-engine/seatunnel-engine-client
-am \
'-Dtest=*FlowLifeCycle*Test,SeaTunnelTaskStateTest,ErrorHandling*Test,ErrorHandler*Test'
\
-Dsurefire.failIfNoSpecifiedTests=false verify
```
The local test JVM used the existing Byte Buddy agent to work around Mockito
self-attachment restrictions. No dependency or build configuration was changed.
Full repository tests, the distributed/Docker matrix and Maven Failsafe were
not run. Full-job tests use LOG wrappers. ROUTE cleanup uses a real handler
with a mocked writer, without an external error sink.
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]