SEZ9 commented on PR #13152: URL: https://github.com/apache/seatunnel/pull/13152#issuecomment-6705930814
Thanks @davidzollo, and thanks for going back and correcting the CI reading yourself — the Python tests for this change do live in the separate SeaTunnel CLI workflow, so the Maven lanes being skipped is expected for a Python-only diff. For the record, matching what you found: `354 passed, 3 subtests passed` on both 3.10 and 3.13, which includes the eight tests in `test_orchestrator_clarification_rounds.py`. One detail worth stating because it is the part that could silently rot: the bound is only meaningful if both question exits go through `_ask`. If a future change adds a third exit that sets `pending_question` directly, the loop comes back and no existing test would notice. That is why the counter lives in `_ask` rather than at the call sites, but it is a convention rather than something the compiler enforces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
