ryanmeowy commented on PR #13145:
URL: https://github.com/apache/seatunnel/pull/13145#issuecomment-6701378505

   Thanks for the approval and for the careful re-read. All four polish notes 
are addressed in `cb94d4ef`.
   
   **Issue 1 — `INTERNAL` was missing from the affected-jobs line.** You are 
right, and it is worth being precise about why: `SQLEngineFactory.getSQLEngine` 
has a fall-through `case ZETA: case INTERNAL: return new ZetaSQLEngine();`, so 
both enum values reach the exact same evaluator. Both language versions now 
read "with the `ZETA` engine (the default) or the `INTERNAL` engine, which maps 
to the same implementation".
   
   **Issue 2 — misplaced comment.** Moved inside the `LikeExpression` branch, 
where it explains the block it sits in, instead of dangling above 
`ComparisonOperator`.
   
   **NULL wording.** Reworded to say the predicate evaluates to false, then 
spell out the two consequences: a `where` clause drops the row, a `case when` 
condition selects the `else` branch. I checked that against 
`ZetaSQLFunction.executeCaseExpr`, which falls through to `getElseExpression()` 
when no `when` is true, so the wording now matches both call sites the section 
claims to cover.
   
   **Fixture comment.** Corrected — `%` is literal in a regex, so `rlike 
'J%ng'` matches only the literal text `J%ng`, not "never anything".
   
   **PR description** is refreshed separately: the diff line now reflects the 
real file list, the checklist no longer claims docs and 
`incompatible-changes.md` are "not applicable", and the test count matches what 
is actually there.
   
   Verification for this commit: `ZetaSQLFilterTest` 13/13 green, 
`spotless:check` green on both the transforms module and the E2E module, and 
the fixture re-checked through the same simulation (one row `[1, Joy Ding, 0, 
1, 1, 0]`, all rules pass).
   
   One note on the branch: `dev` moved while this was open, and GitHub now 
reports the PR as `DIRTY`. The conflict is only in the two 
`incompatible-changes.md` files — a new "Databend source: a DECIMAL column is 
read as DECIMAL instead of STRING" entry landed in the same `## dev` block. 
Both entries are independent, so I will resolve it by keeping both. I am not 
force-pushing or rewriting anything; it will just be a merge from `dev` so the 
diff stays reviewable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to