DanielLeens commented on PR #13143: URL: https://github.com/apache/seatunnel/pull/13143#issuecomment-6682636790
Thanks @ryanmeowy, that plan works for me. Both notes were non-blocking, so keeping this head unchanged is the right call now that the Apache `Build` and `Signal pull request update` checks are both green on `f666fb8fe`. A follow-up PR is a good fit for the two items: the `/tmp/seatunnel/text_null_partition` cleanup in `LocalFileIT`, and the NULL-partition sentence for the other file sinks. Since the behavior lives in the shared `AbstractWriteStrategy`, one docs PR covering all the file sink pages (en and zh) is easier to review than spreading it across connector PRs. My approval on this head stands. The remaining step is a committer review; nothing else is needed from you here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
