DanielLeens commented on PR #11206: URL: https://github.com/apache/seatunnel/pull/11206#issuecomment-6594199885
Pushed `c3d11fc6475` (two commits on top of `d4faf1ea1aa`, no production code changed) for the blockers listed in the latest review. **1. Wildcard E2E failure (Issue 4), `95b4946ee39`.** Both MySQL CDC jobs of run 41164176211 ([JDK 11](https://github.com/DanielLeens/seatunnel/actions/runs/41164176211/job/124440278792), [JDK 17](https://github.com/DanielLeens/seatunnel/actions/runs/41164176211/job/124440278762)) failed only in `testMysqlCdcByWildcardsConfigWithNewlyAddedTable` (10/10 errors, `ConditionTimeout` at `AbstractMysqlCDCITBase:1325`). The log shows the cause before the timeout: ``` ConnectException: The Kafka Connect schema name 'mysql_binlog_source.source.payments_rt_...`bad.Value' is not a valid Avro schema name and its replacement 'mysql_binlog_source.source.payments_rt_..._bad.Value' conflicts with another different schema ``` Debezium sanitizes both `<prefix>;bad` and `` <prefix>`bad `` to `<prefix>_bad` and stops the connector, so SeaTunnel's identifier admission never sees the second CREATE and the valid runtime table is never delivered. The fixtures are now `<prefix>_semicolon;bad` and `` <prefix>_backtick`bad ``: both unsafe characters are still exercised, their sanitized names differ, and all assertions, waits and cleanup are unchanged. **2. Runnable example, `c3d11fc6475`.** Added `driver = "com.mysql.cj.jdbc.Driver"` to the EN/ZH MySQL-CDC runtime-table example (required by `JdbcSinkFactory.optionRule`, as in the E2E config). **3. Downgrade restriction.** Recorded in `docs/{en,zh}/introduction/concepts/incompatible-changes.md`: checkpoints that contain runtime-registered tables cannot be restored by a version without this feature; old-format checkpoints still restore; jobs with `scan.binlog.newly-added-table.enabled = false` (the default) are unaffected. @SEZ9, your F1-F8 status questions were answered item by item in my review of `d4faf1ea1aa`; nothing in this push changes those answers. Only `spotless:apply`/`spotless:check` on the MySQL CDC E2E module were run locally. The current-head MySQL CDC result will come from the fork Build for `c3d11fc6475`; I will not claim it before it has run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
