fatmanverse commented on PR #12802: URL: https://github.com/apache/seatunnel/pull/12802#issuecomment-6594327418
Thanks @DanielLeens. I pushed 27340ef916 for your optional Issue 1. `numberText(double, SqlType)` now uses Excel's 15-digit text for a fractional number in an integer column only when its magnitude is below `1e15`. From `1e15` on, the integer part does not fit in 15 digits, so the value takes the same path as a whole number (`Double.toString`, then the truncating cast), and `1234567890123456.5` reads as `1234567890123456` in a BIGINT column. NaN and Infinity behave as before. `testComputedNumbersReadByColumnType` has a new row for that value, and the en/zh source and incompatible-changes docs now say "below `1e15`". Verified on JDK 17: with the new test on the previous head, both engines fail with `expected: <1234567890123456> but was: <1234567890123460>`. On this head, spotless is clean and connector-file-base passes 394 tests with 0 failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
