SEZ9 commented on issue #13075: URL: https://github.com/apache/seatunnel/issues/13075#issuecomment-6593764494
Thanks for the clarification, @SEPURI-SAI-KRISHNA — that settles the locale-restoration concern. Saving the default locale plus the `FORMAT` and `DISPLAY` category defaults before the `try` and resetting all three in `finally` is exactly what I wanted to see; with that, a failed assertion in either `testConvertDoesNotDependOnTheDefaultLocale` or `testInstanceNamePropertyDoesNotDependOnTheDefaultLocale` cannot leak `tr-TR` or `az-AZ` into the rest of the JVM, and the tests can run in the normal CI build without extra `-D` flags as you described. Also noted on the follow-up scope: with the other dialects, `CollationBasedSplitter` and the Xugu catalog being handled in #13079 and #13083, and the remaining `where` prefix check in `SqlWhereConditionHelper` being locale-neutral, I agree there is nothing further for you to open here, and keeping #13077 limited to the SQL Server type converter and URL parser is the right call. Nothing else outstanding from my side on this issue. I will finish the review on #13077 itself; once it lands, please drop a short note here so we can close this issue referencing the fix. <!-- streview-comment:2234 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
