SEPURI-SAI-KRISHNA commented on PR #13077:
URL: https://github.com/apache/seatunnel/pull/13077#issuecomment-6572221488
@DanielLeens thanks for the review. Issue 1 is done in the latest commit.
`JdbcSqlServerIT.testCatalogReadsColumnTypesUnderTurkishLocale` creates a table
with `int`, `bigint` and `datetime2` columns, and under `tr-TR` and then
`az-AZ` in the test JVM builds a catalog from the IT's URL and reads the table
through it. It builds its own catalog because `testCatalog` closes the shared
one, and that way the URL parser runs under the locale too. The locale is
restored in `finally`.
I checked that it detects the bug, against SQL Server 2022. With this PR it
passes. With the two changed classes as they are on `dev`, it fails with
`COMMON-20 ... {"c_int":"İNT","c_bigint":"BİGİNT","c_datetime2":"DATETİME2"}`,
and the locale is still restored. The IT server is a default instance, so the
`instanceName` case stays with the unit test. The PR description is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
