DanielLeens commented on PR #11809: URL: https://github.com/apache/seatunnel/pull/11809#issuecomment-6557778497
Thanks @SEZ9. Here are the unchanged-head implementation pointers for F1-F8: - F1/F2: `CoordinatorService.java:1314-1317` captures closingJobHistoryService immediately after the clear guard; :1363-1366 closes that captured instance. The single assignment at :640-643 explicitly says never to reuse the old view and constructs a new JobHistoryService. - F3: `JobHistoryService.java:159-184` tracks acquired IDs, rolls back state/metrics registrations on partial construction and rethrows the original RuntimeException. The quiet removal helper catches removal exceptions, so rollback failure does not replace that original exception. - F4: `JobHistoryServiceListenerCleanupTest.java:78-102` uses try-with-resources for the positive control and repeated close cases, including assertion failure cleanup. - F5: `JobHistoryService.java:475-493` logs HazelcastInstanceNotActiveException at fine level; other Exceptions are warnings with registration ID and store/map name. This is best-effort deregistration, not a guarantee of removal after an arbitrary remote failure. - F6/F7/F8: JobHistoryService implements AutoCloseable (:71); its registration accessor is package-private and VisibleForTesting (:226-227); the cleanup test extends AbstractSeaTunnelServerTest<JobHistoryServiceListenerCleanupTest> (:58-59). The earlier queued-CI fact has changed. The [exact-head fork run](https://github.com/DanielLeens/seatunnel/actions/runs/41165514671) is complete/cancelled and Apache Build is TIMED_OUT. Check Helm Chart and Sanity check results are cancelled; the executed source/unit/integration lanes in this attempt are successful, but that is not a complete green Build. The run owner should first check for an active newer attempt, then resume those remaining required jobs. Cancellation supplies no demonstrated source fix in dev, so sync alone is not a cure. The source conclusion stays clear; Daniel is the author and cannot provide independent approval. A write-capable independent maintainer owns the final approval/merge gate. Checked 2026-11-01T12:13:11.960780+00:00; unchanged head `993f3fdbeeab550c462d795c55b85e217dc1c51f`, base `dev`; compare `diverged`, ahead 11 / behind 9; merge `blocked` / `BLOCKED`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
