sharpca commented on issue #13079:
URL: https://github.com/apache/seatunnel/issues/13079#issuecomment-6555095855
Thanks for the guidance. #13083 now covers all ten converters plus the scan
you asked for.
**`Locale.ROOT` in the ten converters** — every `toUpperCase()` /
`toLowerCase()` in the converters listed in the report now passes `Locale.ROOT`
(34 call sites in the PR).
**Turkish locale test** — `JdbcTypeConverterLocaleTest` sets `new
Locale("tr", "TR")`, converts a type name through each affected converter, and
restores the previous default in `@AfterEach`, so the locale cannot leak into
other tests sharing the JVM. It covers `INTEGER`, `BIGINT`, `INT4` and the
other names from the table.
**Result of the scan of the rest of `connector-jdbc`** — three more places
lower-cased with the default locale:
| Location | Call |
| --- | --- |
| `MysqlDialect`, `OceanBaseMysqlDialect`, `OracleDialect`,
`RedshiftDialect`, `SqlServerDialect`, `YashanDbDialect` |
`getQuery().toLowerCase()` in the row count `WHERE` check |
| `CollationBasedSplitter` | `s.toLowerCase()` in the case insensitive
collation normalisation |
| `JdbcSourceFactory` | `value.toLowerCase().startsWith("where")` in the
`where_condition` prefix validator |
These are fixed in the same PR. The six dialects now follow the pattern
`PostgresDialect` already used here. `CollationBasedSplitter` is included
because the locale changes the comparison result there, not only the spelling
of a constant.
`JdbcDialect` / `CatalogUtils` are left to #13063 and the MySQL / OceanBase
/ SQL Server converters to #13076 and #13077, as noted in the report, so the
PRs stay disjoint.
**Verification** (JDK 17, `./mvnw -pl
seatunnel-connectors-v2/connector-jdbc`):
- `JdbcTypeConverterLocaleTest` — 1 test, 0 failures
- `MysqlDialectTest`, `OracleDialectTest`, `SqlServerDialectTest`,
`YashanDbDialectTest`, `JdbcSourceFactoryTest` — 46 tests, 0 failures
- `spotless:check` — passed
The PR workflows are still waiting for approval (`action_required`), so none
of this has run in CI yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
