SEPURI-SAI-KRISHNA commented on PR #13063: URL: https://github.com/apache/seatunnel/pull/13063#issuecomment-6542798269
@DanielLeens thanks, you are right about Issue 2, and my earlier description was wrong. `"uppercase"` and `"lowercase"` contain no `i`, so their enum lookup never failed on a Turkish or Azerbaijani worker. A job there with one of these modes produced `USER_İD` or `user_ıd`, and after this change it produces `USER_ID` or `user_id`. So it is a behaviour change for working jobs, not only a startup fix. Added in the new commit: - `incompatible-changes.md`, en and zh: what changes, that only Turkish or Azerbaijani default locales are affected, and the migration step (rename such tables or columns to the ASCII spelling before upgrading). - The `field_ide` section of the JDBC sink documentation, en and zh: the conversion uses `Locale.ROOT`, with an example. Issue 1: I added `JdbcSinkTest.createWriterDoesNotDependOnTheDefaultLocale`. It builds a real `JdbcSink` (MySQL dialect, `query` only, `field_ide` not set) and calls `createWriter` under `tr-TR` and `az-AZ`. That is the exact path that failed for every such sink. With the `CatalogUtils` fix reverted it fails with `No enum constant ...FieldIdeEnum.ORİGİNAL`. I did not extend `JdbcMysqlIT`. The failure depends on the default locale of the engine JVM, and the E2E suites run the engine in a container with that container's default locale. Covering it there would mean starting the engine with a Turkish locale for this one case. Note: the latest head before this commit, `7111c99e8`, is a merge of `dev` done from the GitHub UI, not a change to the locale code. Checks, JDK 17: `JdbcSinkTest`, `CatalogUtilsTest` and `MysqlDialectTest` 27 tests, 0 failures; `spotless:check` clean; `seatunnel-ci-tools` 34 tests, 0 failures. The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
