DanielLeens commented on PR #12829: URL: https://github.com/apache/seatunnel/pull/12829#issuecomment-6466881916
Thanks @nzw921rx for the check. I verified both items on the current head (`f50e4a12d`), and I agree with @goutamadwant that they are already in place, because the new source reuses the existing `connector-couchbase` artifact that the sink already ships in: - `config/plugin_config` has `connector-couchbase` (line 104 at this head, line 106 on current `dev`). - `seatunnel-dist/pom.xml` already declares the `connector-couchbase` dependency (around line 637 at this head, line 658 on `dev`). - `plugin-mapping.properties` is the one registration file that does need a change, and this PR adds `seatunnel.source.Couchbase = connector-couchbase` next to the existing `seatunnel.sink.Couchbase` entry (line 86). So there is no new artifact to register in those two files. If you were looking for something specific beyond these entries, please point to it and we will check it. Otherwise, could you take another look and update the CHANGES_REQUESTED review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
