DanielLeens commented on PR #13021: URL: https://github.com/apache/seatunnel/pull/13021#issuecomment-6466872355
Thanks @Asthenia0412, and thanks to SEZ9 for the extra review. I rechecked the Edge Agent finding against head ab7afd6 and it is valid. I missed it in my earlier pass. `DbCommandArgs.buildCommand()` returns the same `EdgeAgentDbHelpCommand` when `getSubcommand() == null` and when the subcommand is `help`. That command now exits with `HELP_EXIT_CODE` (0). So a bare `db`, or `db --id 5` with the verb missing, prints usage and exits 0. That contradicts the note in `incompatible-changes.md` that invalid arguments still exit nonzero. A small commit is needed here: - Keep exit 0 only for the explicit `db help` verb and for `-h/--help`. - Make the missing-subcommand path print usage and exit `USAGE_EXIT_CODE` (for example by passing the exit code into the help command from `buildCommand()`). - Add `db` (no args) and `db no-such-subcommand` cases to `EdgeAgentHelpExitCodeTest`, and pin the exact expected code instead of `!= 0`. - List the argument-less forms (bare `seatunnel-connector.sh`, bare `db`) in the en and zh upgrade notes. One process note: the `Build` check is still `action_required` on this head, so CI has not run yet. Please make sure workflows run for your fork when you push the fix. We will re-review once the new commit lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
