NganWave commented on PR #12810: URL: https://github.com/apache/seatunnel/pull/12810#issuecomment-6420368742
@DanielLeens @SEZ9 Thanks for the detailed review! About Issue 2: the desensitization concern was intentionally left out of scope. This was discussed in a previous PR #12491 (Issue 5: parseValue error message `ConfigValueUtils.java`), where the plan was to handle secret masking as a dedicated follow-up rather than in this change. I'm working on this PR only in my spare time, so I'll only reply to the desensitization issue in this thread for now. That said, I have the patience to keep refining this PR, and I'll handle the other comments one by one and push incremental commits. For desensitization itself, I'll open a separate PR that traces the full path from `ParameterSplitter` at the CLI stage, through `ConfigBuilder` and `ConfigUtil`, to the final `ReadOnlyConfig` object — not just `PlaceholderUtils`. And I will audit every point I can identify where user-controlled values can reach exception messages or logs. I'll link the follow-up PR back to this thread once it's up. Thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
