DanielLeens commented on PR #11401: URL: https://github.com/apache/seatunnel/pull/11401#issuecomment-6397822044
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/wipheg/seatunnel/actions/runs/40038741043) is now **completed with cancelled** for `7ac86f076758d2b745094a719098ac4bd35dda09`. This is a gate correction, not a second full source review of that unchanged head. A correction to the overall workflow fact: this fork run is now **cancelled**, rather than simply failed. That does not clear the compile failures already reported. The inspected unit-test/dependency-license samples still fail because the TiDB abstract deserializer declares duplicate `collect(SeaTunnelRow, Collector<SeaTunnelRow>)` methods; compile-dependent connector jobs also failed. These are real failed jobs inside a cancelled overall run, not passing tests. Previous High Issue 1 remains the source blocker: remove the duplicate method, preserving the intended metadata changes, and rerun current-head compilation and required checks. Latest dev does not contain that duplicate; a generic sync without fixing the PR's retained declaration is not a substitute. The previous Low documentation-placement suggestion remains non-blocking. This updates the CI/process description only and does not issue another full review of unchanged source. Comparison against dev is `diverged`, ahead 4 / behind 13; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. The previous source blocker remains; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
