DanielLeens commented on PR #12970: URL: https://github.com/apache/seatunnel/pull/12970#issuecomment-6393680740
Addressed the four points in [the existing review](https://github.com/apache/seatunnel/pull/12970#pullrequestreview-5638024105) with commit `bfe60da4e81dd3f6c63f0ec61249a3b3b469fdf8`: 1. Replaced the unavailable `ReadonlyConfig.getConfData()` call with Apache's `getSourceMap()`, retaining nested object values. All six failed lanes of the previous Build stopped at this compile error; I did not retry that superseded head. 2. Restricted unquoted case normalization to schema/table and preserved the configured database spelling. Tests now check the database/schema/table components separately, and the lowercase E2E uses lowercase source URL, database-names and table-names. 3. Explicitly documented the Vitess restore behavior correction. Added an independent fixed fixture of the pre-PR JSON writer layout, checking decoder-compatible identity and unchanged schema/payload on reserialization. The fixture is source-derived, not a checkpoint captured from an old running binary. 4. Added table-ID WARN messages when catalog key metadata is missing. These lookups occur during snapshot split planning, not per CDC row. Also clarified the user-configured-key comment, kept test implementation details in this PR instead of the user guide, and removed the inaccurate prior static-check statement. Local Spotless checks passed for DB2, Vitess and DB2 E2E; compilation, unit tests and E2E remain GitHub CI responsibilities under the agreed validation policy. The new exact-head [Build](https://github.com/DanielLeens/seatunnel/actions/runs/40163820782) is queued at this snapshot. No passing runtime or merge-readiness claim is made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
