DanielLeens commented on PR #12881: URL: https://github.com/apache/seatunnel/pull/12881#issuecomment-6391370873
Thanks @goutamadwant for the quick follow-up and for the fix in `beeda6fac`. I re-reviewed the full PR at head `311b653ab` earlier today (see my last review): the High-severity stale-row blocker is resolved from the source side, and I found no remaining blocking issues in the source, tests or docs. I will move my review state to approve once `Build` is green on the final head. Two things are needed on your side before that can happen: 1. **Merge conflict.** GitHub now reports this PR as conflicting with `dev` (it is currently 5 commits behind). Please sync with the latest `dev` and resolve the conflicts. Since the conflict resolution will produce a new head, I will re-check the diff of that merge before approving, so please keep the resolution limited to the conflicting hunks. 2. **CI.** The `Build` check on `311b653ab` has not finished yet. As the workflow runs in your fork, it is your fork's run that decides the result, so please let it complete (or re-run it after the sync). If a lane fails, tell me which one and I will check whether it relates to this diff. I cannot approve or trigger workflow runs from my side as a reviewer, so a maintainer with write access would need to do that if the run stays pending. The non-blocking suggestions from my review (Javadoc on the grouping contract, refreshing the PR description) can be picked up in the same push. Thanks again for the patience and the thorough tests! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
