SEZ9 commented on issue #12968: URL: https://github.com/apache/seatunnel/issues/12968#issuecomment-6379506047
Thanks for the detailed analysis and the converter comparison table. Having `StructConverter` and `MapConverter` return `null` for a null cell in the generics overload, matching what the three list converters already do, sounds like the right fix. Since you're willing to submit a PR, please include a unit test in `connector-common` that covers a null `ROW` cell, a null `MAP` cell, and a genuinely empty map cell, so that absent and empty stay distinct as you describe. If you can get a `MapVector` populated in that test, it would also close the gap you noted in `ArrowToSeatunnelRowReaderTest`, where the `MAP` column is never actually written. <!-- streview-comment:1996 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
