DanielLeens commented on PR #12673:
URL: https://github.com/apache/seatunnel/pull/12673#issuecomment-6368580301
I prepared a small, directly applicable patch for the shared-table test
ordering on head `78581d5936a29fcabcccd665bbbf5acb77c74001`. `testIsExistsData`
must run before `testDropTable`; the patch gives the remaining methods unique
order values and keeps all existing assertions.
Save the diff below as `duckdb-test-order.patch`, then run `git apply
--check duckdb-test-order.patch` and `git apply duckdb-test-order.patch` on
that head:
```diff
diff --git
a/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/duckdb/DuckDBCatalogTest.java
b/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/duckdb/DuckDBCatalogTest.java
index 500de5414b1..8ea9050f61f 100644
---
a/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/duckdb/DuckDBCatalogTest.java
+++
b/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/duckdb/DuckDBCatalogTest.java
@@ -208,7 +208,7 @@ public class DuckDBCatalogTest {
}
@Test
- @Order(7)
+ @Order(8)
public void testDropTable() throws Exception {
TablePath tablePath = getMainTablePath(TABLE_NAME);
TablePath copyPath = getMainTablePath(TABLE_NAME_COPY);
@@ -219,7 +219,7 @@ public class DuckDBCatalogTest {
}
@Test
- @Order(8)
+ @Order(9)
public void testMetadataLookupWithApostrophes() throws Exception {
TablePath tablePath = TablePath.of(DATABASE_NAME, "odd'schema",
"odd'table");
try (Statement statement =
catalog.getConnection(jdbcUrl).createStatement()) {
@@ -310,7 +310,7 @@ public class DuckDBCatalogTest {
}
@Test
- @Order(8)
+ @Order(10)
public void testBitAndLongEnumLabelUseUnboundedSinkTypes() throws
Exception {
String label = String.join("", Collections.nCopies(400, "m"));
try (Statement statement =
catalog.getConnection(jdbcUrl).createStatement()) {
```
Validation: scoped `./mvnw spotless:apply -pl
seatunnel-connectors-v2/connector-jdbc -nsu -Dmaven.gitcommitid.skip=true`
completed successfully, and the patch passed `git apply --check --cached`
against the untouched index at the pinned head. Compilation, unit tests and
integration tests were not run locally; fresh GitHub CI is required after
applying it.
This addresses only the ordering issue, not the remaining save-mode/catalog
correctness findings. I checked the prerequisite again: #12506 is still open
and has conflicts at `f39e9c818568c2590b49c406dc8b21f62f5e1f88`. The
attached-catalog metadata/CREATE path needs to be made consistent with
DROP/TRUNCATE before the feature can be considered fixed; the `default`
placeholder qualifier and real save-mode flow coverage also remain to be
addressed after that prerequisite.
The current [Build
check](https://github.com/apache/seatunnel/runs/112716851994) is
`action_required` because it could not detect a workflow run. Please enable
GitHub Actions in your fork before committing the patch so that the new commit
can produce a linked Build run. I have read-only access to the source branch,
so this comment supplies the patch for you to apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
