DanielLeens commented on code in PR #11896:
URL: https://github.com/apache/seatunnel/pull/11896#discussion_r4357153467
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/pom.xml:
##########
@@ -93,5 +93,11 @@
<version>${junit4.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
+1 to @nzw921rx, and thank you for flagging this. I raised the same point in
my earlier rounds (Low severity, non-blocking) and I re-checked it on the
current head `4dc263f1a6e9`: the root `pom.xml` already declares
`mockito-inline:${mockito.version}` with test scope in its direct
`<dependencies>` block (about lines 712-717), so every child module inherits
it. The pre-existing `MongodbRecordUtilsHeartbeatTest` in this same module
already uses `Mockito.mockStatic(...)` without any module-level declaration,
which is the evidence that the new block here adds nothing.
Concrete next step for @zhang-arvin: delete this `<dependency>` block
(`org.mockito:mockito-inline`) from `connector-cdc-mongodb/pom.xml`, which also
leaves this PR with no `pom.xml` change at all, and push. The production change
in `MongodbScanFetchTask.java` and the tests stay as they are. I only did a
static read here; nothing was run locally.
On CI: the latest `Build` run for this head ended as cancelled (not a
failure caused by the diff), so the push that removes the pom block will also
give you a fresh run on a new head. I will recheck the new head once it is
pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
